Split TemplateType::isSubTypeOf() and TemplateType::isAcceptedBy() #1001
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TemplateType::isAcceptedBy() delegates to TemplateType::isSubTypeOf(). Because of this, bounds are compared with isSubTypeOf(), which gives undesirable results in the context of isAcceptedBy().
For instance,
ArrayAccess->isSuperTypeOf(Traversable)
beingmaybe
causes(T of ArrayAccess)->accepts(Traversable)
to bemaybe
as well.In this PR I split the implementations of
TemplateType::isSubTypeOf()
andTemplateType::isAcceptedBy()
, so thatisAcceptedBy()
can compare bounds withaccepts()
.This fixes phpstan/phpstan#6589